Форумы портала PHP.SU :: Версия для печати :: Оптимизация кода и аналог на JS

Страниц (1): [1]

1. Noobster - 20 Июля, 2022 - 17:16:45 - перейти к сообщению

Добрый день,
Имеется массив, где идёт перечисление диапазон дней, и цена скидки.
Надо на каждый день отнимать цену скидки.
Код работает, но думаю требуется оптимизация, подскажите как лучше.

И ещё как аналогично написать на JS.
Спасибо Ниндзя

PHP:
скопировать код в буфер обмена

<?PHP
$start_day = new Carbon("07/27/2022 03:40 pm");
$end_day = new Carbon("07/30/2022 03:40 pm");
$price = "45.25";
 
// Надо подправить для тестирования
$discounts = "[0] => Array ( [0] => 1-2 [1] => 0 [2] => 10 ) [5] => Array ( [0] => 3-7 [1] => 5 [2] => 15 ) [10] => Array ( [0] => 8-12 [1] => 10 [2] => 20 )";
 
$total_days = $start_day->diffInDays($end_day);
$total_price = $price*$total_days;
 
$day = $start_day->diffInDays($end_day);
foreach ($discounts as $value) {
        $day_value = explode("-", $value[0]);
        $min_day = $day_value[0];
        $max_day = $day_value[1];
        if (in_array($day, range($min_day,$max_day))) {
                $price_discount = $value[1] * $day;
                $total_price -= $price_discount;
                break;
        }
}
 
echo $total_price;
?>

function getDateTime($date){

$format = "m/d/Y G:ia";

return DateTime::createFromFormat($format, $date);

function getDiffInDays($dateTimeStart, $dateTimeEnd){

return $dateTimeStart->diff($dateTimeEnd)->d;

$start_day = getDateTime("07/27/2022 03:40 pm");

$end_day = getDateTime("07/30/2022 03:40 pm");

0 => [0 => "1-2", 1 => "0", 2 => "10"],

5 => [0 => "3-7", 1 => "5", 2 => "15"],

10 => [0 => "8-12", 1 => "10", 2 => "20"]

$total_days = getDiffInDays($start_day, $end_day);

$total_price = $price * $total_days;

foreach ($discounts as $value) {

$day_value = explode("-", $value[0]);

$min_day = $day_value[0];

$max_day = $day_value[1];

print_r(range($min_day,$max_day));

if (in_array($total_days, range($min_day,$max_day))) {

$price_discount = $value[1] * $total_days;

$total_price -= $price_discount;

getDiffInDays = function(dateStartStr, dateEndStr){

dateStart = new Date(dateStartStr);

dateEnd = new Date(dateEndStr);

DiffInTime = Math.abs(dateEnd.getTime() - dateStart.getTime());

return DiffInTime/(1000 * 3600 * 24);

range = (a,b) => [...Array(parseInt(b)+1).keys()].slice(parseInt(a));

//-------------------------------------------------------------------

0:{0:"1-2", 1:"0", 2:"10"},

5:{0:"3-7", 1:"5", 2:"15"},

10:{0:"8-12", 1:"10", 2:"20"}

dateStartStr = "07/27/2022 03:40 pm";

dateEndStr = "07/30/2022 03:40 pm";

total_days = getDiffInDays(dateStartStr, dateEndStr);

total_price = price * total_days;

document.write("price: "+price+ " ");

document.write("dateStart: "+dateStartStr + " ");

document.write("dateEnd: "+ dateEndStr + " ");

document.write("total days: "+ total_days + " ");

document.write("total price: "+ total_price +" ");

for(ind in discounts)

value = discounts[ind];

day_value = value[0].split("-");

min_day = day_value[0];

max_day = day_value[1];

console.log(day_value);

if(range(min_day, max_day).includes(total_days))

price_discount = value[1] * total_days;

total_price -= price_discount;

document.write("---------------------------------- ");

document.write("price discount: "+ price_discount +" ");

document.write("total price: "+ total_price +" ");

dateStart: 07/27/2022 03:40 pm

dateEnd: 07/30/2022 03:40 pm

----------------------------------